[Feature Request] Support LF line breaks as well as CRLF line breaks · usebruno/bruno#326 | Good First Issue

(2 留言) (0 反應) (0 負責人)JavaScript (2,403 fork)batch import

good first issuehelp wantedmodule-request

倉庫指標

Star: (43,787 star)
PR 合併指標: (平均合併 6天 21小時) (30 天內合併 96 個 PR)

描述

Currently, when a client sends LF instead of CRLF as a newline character, Bruno errors out with the following message:

Error invoking remote method 'send-http-request': Error: Parse Error: Missing expected CR after header value

Insomnia does support LF newlines, and I think Bruno should as well; RFC7230 Section 3.5 also allows for this:

Although the line terminator for the start-line and header fields is the sequence CRLF, a recipient MAY recognize a single LF as a terminator and ignore any preceding CR.

貢獻者指南

研究方向: 檢查 Bruno 程式碼庫中 HTTP 請求解析發生的位置，很可能在處理傳入請求文字的模組中。錯誤提示正在使用自訂解析器。調查 'send http request' 處理程序，找到進行標頭解析的位置，並根據 RFC7230 第 3.5 節修改它以接受 LF 作為有效的行終止符。考慮使用 CRLF 和 LF 兩種變體進行測試。
技術棧: javascript
領域: backendapi
議題類型: 功能
難度: 3
預計時間: 1-2 天
活動狀態: 活躍
清晰度: 清晰
前置要求: HTTPNode.js
新手友善度: 60