usebruno/bruno

[Feature Request] Support LF line breaks as well as CRLF line breaks

Open

#326 建立於 2023年10月4日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)JavaScript (43,787 star) (2,403 fork)batch import
good first issuehelp wantedmodule-request

描述

Currently, when a client sends LF instead of CRLF as a newline character, Bruno errors out with the following message:

Error invoking remote method 'send-http-request': Error: Parse Error: Missing expected CR after header value

Insomnia does support LF newlines, and I think Bruno should as well; RFC7230 Section 3.5 also allows for this:

Although the line terminator for the start-line and header fields is the sequence CRLF, a recipient MAY recognize a single LF as a terminator and ignore any preceding CR.

貢獻者指南

技術棧
javascriptnodejs
領域
backendapi
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Examine the Bruno codebase for where the HTTP request parsing occurs, likely in a module that handles incoming request text. The error suggests a custom parser is being used. Investigate the 'send http request' handler to find where header parsing is done and modify it to accept LF as a valid line terminator per RFC7230 Section 3.5. Consider testing with both CRLF and LF variations.