unisonweb/unison

externally updated `_head` isn't detected in `ucm`

Open

#886 建立於 2019年10月23日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Haskell (6,624 star) (304 fork)batch import
bugcodebase-manager / ucmhelp wanted

描述

This can cause weirdness if there are two instances of ucm running backed by the same codebase.

I think the code to do anything about it is commented out (which we should fix) but there is code to display a warning, which also isn't firing.

If the external change leaves multiple heads, ucm should first:

  • issue a message to the console, including the short hashes of the previous loopstate root hash, and of the newly detected heads (see reflog implementation for example of printing short hashes).
  • merge the multiple heads (Branch.merge?)

Then (multiple heads or single head), ucm should:

  • write the external change to the reflog
  • update LoopState

貢獻者指南

技術棧
無
領域
clitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Knowledge of Unison's ucm internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
Examine the codebase for commented out sections related to detecting external changes to ` head` in `ucm`. Look at the reflog implementation (e.g., in files like `Reflog.hs`) to understand how short hashes are printed. Investigate `Branch.merge` for merging multiple heads. The warning code that isn't firing should be located and fixed. Ensure all checkboxes in the issue are addressed.