umputun/remark42

Separate vendor from widgets bundles

Open

#901 建立於 2021年2月25日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Go (5,500 star) (432 fork)user submission
enhancementfrontendgood-first-issuehelp wanted

描述

It's a really good thing in the case when remark42 installed on a page with the two widgets comments and last comments. Both of the widgets have bundles that include preact, redux, etc. It could be much more effective to separate vendor bundle and use the same piece of code for these widgets.

貢獻者指南

技術棧
javascripttypescriptgo
領域
frontendperformance
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
familiarity with Go build systemunderstanding of JavaScript bundling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the current build process in the repository, likely involving Webpack or a similar bundler for the frontend widgets. Identify the common vendor dependencies (e.g., preact, redux) shared between 'comments' and 'last comments' widgets. Then propose splitting the vendor code into a separate bundle that can be cached and reused. Look for existing build configurations in the repository, such as webpack.config.js or Makefile, and study how bundles are currently generated. The implementation should ensure backward compatibility and maintain the existing widget APIs.