umputun/remark42

Disabling negative voting result causes lack of signs

Open

#727 建立於 2020年6月7日

在 GitHub 查看
 (6 留言) (1 反應) (0 負責人)Go (5,500 star) (432 fork)user submission
frontendgood-first-issuehelp wanted

描述

Enabling POSITIVE_SCORE changes existing votes as well. This is expected (I guess) but confusing side-effect.

Not sure how to deal with this, but can think of 3 possible solutions:

  1. do nothing
  2. UI not just loose +/- on POSITIVE_SCORE, but also shows all negative values as 0s
  3. UI checks if any vote for the post negative and shows +/- in this case (POSITIVE_SCORE mode only)

/cc @paskal @akellbl4 @Mavrin

貢獻者指南

技術棧
gojavascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic Gofrontend development
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue concerns the display of vote signs when POSITIVE SCORE is enabled. The frontend code (likely in a React component) renders vote icons and should be modified to either show negative values as 0 or conditionally show signs. The backend logic for POSITIVE SCORE is in the Go code. Look at the current implementation of vote display and the handling of the POSITIVE SCORE flag. The maintainer comments may provide additional guidance.