umputun/remark42

Problematic logout doesn't show errors in the UI

Open

#1,455 建立於 2022年7月31日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Go (5,500 star) (432 fork)user submission
bugfrontendhelp wanted

描述

I run remark42 like that: ./remark42.darwin-arm64 server --secret=12345 --url=http://127.0.0.1:8080.

If I was logged in before running that version (with no auth providers) I see a normal comment screen:

If I push the "log out" button, http://127.0.0.1:8080/auth/logout?site=remark request is made with status code 400 which has the following answer:

{
    "error": "providers not defined"
}

The interface shows nothing. In the console, I see the following:

Erroring code:

貢獻者指南

技術棧
javascriptreactgo
領域
full stack
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of GoBasic knowledge of React
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
The issue is that the frontend does not display the error response from the logout API. The error from the backend is a 400 with 'providers not defined'. The frontend code that handles the logout response likely needs to catch and display this error. Look at the frontend's logout function (probably in a component that handles authentication) and ensure it shows the error message.