uber/react-vis

Thoughts on viewBox property

Open

#901 建立於 2018年8月16日

在 GitHub 查看
 (8 留言) (1 反應) (0 負責人)JavaScript (8,615 star) (868 fork)batch import
enhancementhelp wanted

描述

I've been experimenting with react-vis components library and modifying it to pass a viewBox property all the way down to the svg element in XYPlot.

The results so far have been quite promising:

  • The elements inside the graph can easily be deployed in relation to each other using the internal coordinate system
  • Sizes can also be expresses in a way consistent with that system
  • The SVG scales appropriately, and it can be combined easily with flexbox.

So my question is: why is it that this doesn't have support out of the box? Is there any drawbacks I'm not noticing.

Thanks.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Knowledge of ReactUnderstanding of SVG viewBox
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Review the XYPlot component in react vis to understand how SVG attributes are currently passed. Examine the viewBox property specification and how it could be integrated. Look for any prior discussion or PR references in the comments. The issue asks for support out of the box, so research the existing prop passing mechanism and propose a minimal implementation.