uber/react-vis

LineSeriesCanvas in FlexibleXYPlot container renders in incorrect size on retina screens

Open

#1,063 建立於 2018年12月12日

在 GitHub 查看
 (4 留言) (0 反應) (0 負責人)JavaScript (8,615 star) (868 fork)batch import
bughelp wanted

描述

Example: https://codepen.io/marton/pen/aPvody

This can be reproduced by putting any canvas series in a FlexibleXYPlot container as long as devicePixelRatio !== 1.

#605 seems related

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic knowledge of Reactunderstanding of canvas renderingfamiliarity with devicePixelRatio
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue can be reproduced using the provided CodePen example (https://codepen.io/marton/pen/aPvody) where a LineSeriesCanvas inside a FlexibleXYPlot shows incorrect sizing on retina screens (devicePixelRatio !== 1). The related issue #605 (https://github.com/uber/react vis/issues/605) likely provides additional context. To fix, investigate the FlexibleXYPlot and LineSeriesCanvas components in the react vis source code, specifically how they handle device pixel ratio and container dimensions. The fix may involve adjusting the canvas size or scaling context based on devicePixelRatio.