uber/piranha

PiranhaObjC: Use properties.json to specify configuration properties

Open

#51 建立於 2020年6月15日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)Java (2,143 star) (178 fork)batch import
enhancementgood first issuehelp wantedlegacy-objc

描述

Currently PiranhaObjC APIs are hardcoded. See here. Introduce a configuration json file that contains an array of methodProperties with methodName, flagType, returnType and argumentIndex. See below.

{ "methodProperties": [ { "methodName": "isToggleEnabled", "flagType": "treated", "returnType": "boolean", "argumentIndex": 0 }, ... ], }

This properties file will be parsed and the listed APIs will be used for refactoring.

貢獻者指南

技術棧
cppobjective c
領域
tooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Basic knowledge of C++Understanding of JSON
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Review the current hardcoded API definitions in https://github.com/uber/piranha/blob/master/objc/src/XPFlagRefactoring/XPFlagRefactoring.cpp#L40. Investigate how to parse a JSON file (properties.json) containing an array of methodProperties objects with fields methodName, flagType, returnType, and argumentIndex. Look into existing JSON parsing libraries in the project or consider using a lightweight C++ JSON parser. After parsing, replace the hardcoded calls with the dynamically loaded properties. The issue has one comment but no recent maintainer activity; it may benefit from clarifying the expected JSON structure and integration points.