twitter/finagle

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6

Open

#526 建立於 2016年7月13日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Scala (8,864 star) (1,435 fork)batch import
good first issue

描述

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar

貢獻者指南

技術棧
scala
領域
backendobservability
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Scala knowledgeFamiliarity with ThriftUnderstanding of Zipkin endpoint
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue is to add IPv6 support to the Endpoint class in Finagle's Zipkin integration. The key change is in the com.twitter.finagle.zipkin.core.Endpoint class, which currently only supports IPv4. The Zipkin API specification (https://github.com/openzipkin/zipkin api/blob/master/thrift/zipkinCore.thrift#L276) shows that endpoints can now optionally include an ipv6 field as a 16 byte address. To implement this, you'll need to modify the Endpoint Scala class to add an ipv6 field, update its serialization/deserialization to handle the new field, and ensure backwards compatibility with IPv4 only endpoints. The issue also mentions a contributor (@sveinnfannar) who may have further context. Review the existing codebase to understand the current Endpoint implementation and the Thrift binding, then add the ipv6 support accordingly.