twitter/finagle

Support for uploading files in HTTP client

Open

#501 建立於 2016年4月26日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Scala (8,864 star) (1,435 fork)batch import
help wanted

描述

I am abandoning scalaj-http in favour of Finagle. The only feature that I am missing is support for file uploads. From what I have found, there is no direct equivalent to this scalaj-http code:

val response = scalaj.http.Http(url)
  .postMulti(scalaj.http.MultiPart(
    "file",
    file.getName,
    Files.probeContentType(file.toPath),
    new FileInputStream(file),
    file.length(),
    onWrite))

貢獻者指南

技術棧
scala
領域
apibackend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic understanding of HTTP multipart uploadsfamiliarity with Finagle's HTTP client
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
45
研究方向
The issue requests adding multipart file upload support to Finagle's HTTP client, similar to scalaj http's postMulti. To implement, explore the existing HTTP client code, likely in the com.twitter.finagle.http package, specifically request building classes (e.g., RequestBuilder). Look for how request bodies are constructed and how to add multipart/form data. The issue has 3 comments; review them for any additional context or suggestions. Consider examining how other HTTP clients handle file uploads and adapt that pattern to Finagle's API.