tursodatabase/libsql

Total changes is accumulated per Hrana stream, not connection which is wrong

Open

#1,512 建立於 2024年6月27日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C (16,744 star) (490 fork)batch import
buggood first issuehelp wantedremote protocol

描述

We currently implement total_changes() incorrectly for Hrana client-side protocol because we accumulate the changes per stream, but should do it per connection. I merged the incorrect solution as an intermediate step to expose the API to users because fixing this is a bit involved. Hrana does pass connection to stream but turns it into something useless because of the generics trickery there.

貢獻者指南

技術棧
c
領域
database
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Hrana protocolRust genericslibSQL internals
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Review the current implementation of total changes() in Hrana client side protocol. Examine how the stream accumulates changes and understand why the connection parameter is not used due to generics trickery. Look for existing comments or linked PRs for context, then propose a fix to move accumulation to connection level.