tursodatabase/libsql

Auto generate bindings when `libsql-sqlite3` is changed

Open

#1,039 建立於 2024年2月16日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C (16,744 star) (490 fork)batch import
good first issue

描述

Whenever there is a change in libsql-sqlite3, we need to generate the sqlite header files and bindings. These commands to be run:

# this updates libsql-ffi and also libsql-sys
cargo xtask build-bundled 
# this updates bindings required for sqlite3-mc
cargo build --features multiple-ciphers

This is a manual step and easy to miss. It happened in #1027 which was fixed later by #1037

We should automate this, as part of the build process. We should also move multiple-ciphers build within build-bundled, so that there is only one command to run

貢獻者指南

技術棧
rustcshell
領域
build systemdevopstooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Rustcargo build systemC bindingsxtask
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Investigate the current build process in the xtask directory, specifically the build bundled command. Understand how libsql sqlite3 changes are detected (e.g., file modification timestamps). Consider integrating the multiple ciphers build into the same command. Look at PRs #1027 and #1037 for context on the manual step that was missed. Propose a solution that runs both commands automatically when libsql sqlite3 source files change.