tmspzz/Rome

Reduce code duplication in some function

Open

#51 建立於 2017年3月24日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)Haskell (771 star) (54 fork)batch import
help wantedready-to-implement

描述

Enhancement Suggestion

Reduce code duplication in some function.

Steps which explain the enhancement

Example of function which could use some slimming down

Current and suggested behavior

Currently there are tiny differences which lead to a ton of duplication. A more careful design can reduce code duplication.

Why would the enhancement be useful to most users This enhancement does nothing for the users but a lot for code quality and maintenance

貢獻者指南

技術棧
無
領域
build systemdeveloper experience
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Haskell knowledgefamiliarity with Lib.hs
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
Examine the two functions in Lib.hs (lines 290 and 325) to identify shared logic and differences. Propose a refactoring that extracts common functionality into a helper function. The issue is from 2017 with no maintainer feedback, so ensure any changes align with the project's coding style. Consider discussing the approach in the issue before implementing.