Review dynflow-sidekiq exec command · theforeman/foremanctl

(2 則留言) (0 個反應) (0 位負責人)Python (38 個分叉)auto 404

foremangood first issue

倉庫指標

星標: (25 顆星)
PR 合併指標: (PR 指標待抓取)

描述

Based on https://github.com/evgeni/talks/pull/4#discussion_r1932083989 we should review the command:

https://github.com/theforeman/foreman-quadlet/blob/177348fc149e74a4adb6680cb239181f16cf8476/roles/foreman/tasks/main.yaml#L90

This copies the DYNFLOW_SIDEKIQ_SCRIPT (that's also set as an env var) and hardcodes the Rails environment, but do we even need to expose this in the first place? It's based on https://github.com/theforeman/foreman/blob/74ddd8851cebd21c268002e0c82a3619d2a9db66/extras/systemd/dynflow-sidekiq%40.service#L12-L20 but is it better to provide a better /usr/libexec/foreman/sidekiq-selinux wrapper script that has these defaults built in?

貢獻者指南

研究方向: 比較 foreman quadlet 中的命令與上游 systemd 服務檔案。評估 DYNFLOW SIDEKIQ SCRIPT 環境變數和硬編碼的 Rails 環境是否必要。考慮在 foremanctl 中創建一個包含預設值的包裝腳本。
技術棧: pythonshell
領域: backenddevops
議題類型: 重構
難度: 2
預計時間: 1-3 小時
活動狀態: 活躍
清晰度: 清晰
前置要求: Git
新手友善度: 70