thedevdojo/voyager

BREAD Field labels have wrong for attribute

Open

#4,247 建立於 2019年7月6日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)PHP (11,817 star) (2,652 fork)batch import
help wanted

描述

Version information

This is a code issue / error. It is present on the current "master" branch (1.2)

Description

The form label for attribute is not matched with the name field attribute. It is hardcoded: https://github.com/the-control-group/voyager/blob/7835b366babf63940aef18e52615852eb17e2651/resources/views/bread/edit-add.blade.php#L72

This is my suggestion/fix. <label class="control-label" for="{{ $row->field }}">{{ $row->display_name }}</label>

If you prefer a PR just ask.

Expected behavior

Labels should be matched with the corect form field.

貢獻者指南

技術棧
phplaravel
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic HTMLLaravel basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue is in the file resources/views/bread/edit add.blade.php at line 72. The label's 'for' attribute is hardcoded to 'name', but should use {{ $row >field }} to match the input field's name attribute. A one line change is suggested. The issue has been open since 2019 with no assignee or linked PR, so it is available for contribution.