thedevdojo/voyager

Validation connected to Settings

Open

#3,494 建立於 2018年8月25日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)PHP (11,817 star) (2,652 fork)batch import
help wanted

描述

  • Laravel: latest
  • Voyager: latest
  • PHP: 7
  • Database: mysql

Description of problem

Not really a problem, its a feature request.

Proposed solution

n/a

Alternatives considered

n/a

Additional context

As asked here it would be great to have the same validation currently available for Bread also for Settings, this is because you might have users that have to set a number as a settings but turn on adding invalid characters upon setting their settings.

For example we choose a textarea where a customer should typ only numbers, but instead the customer (user) is using text and therefore the input is invalid but did get accepted by the system.

It would be awesome to be able to set de validation variables also for the settings page.

貢獻者指南

技術棧
phplaravelmysql
領域
backend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Familiarity with Laravel validationUnderstanding of Voyager's BREAD systemVoyager development environment
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine Voyager's BREAD validation implementation in VoyagerBreadController.php to understand how validation rules are applied. Then, locate the Settings controller (likely VoyagerSettingsController.php) and identify where settings are saved. Add validation logic similar to BREAD, allowing validation rules to be defined for each setting. Check if the settings table has a column for validation rules (e.g., 'validation') and how those rules are used. There is no linked PR or further discussion, so implementation details are open. Consider also reviewing any existing tests for settings to ensure backward compatibility.