InternalCommandPortListeningCheck always fails for containers built without `/bin/sh` · testcontainers/testcontainers-java#3317

(5 留言) (7 反應) (0 負責人)Java (7,535 star) (1,588 fork)batch import

help wantedtype/bug

描述

Relates to #2984

I'm surprised we've not come across this earlier, but the default TCP port listening detector InternalCommandPortListeningCheck does not work for containers that do not have /bin/sh included.

This predominantly affects images built upon scratch.

The workaround/solution is to use a more application specific WaitStrategy - e.g. an HTTP wait strategy.

However the log messages don't make this easy to realise.

Given that we do both the internal and external port checks for a good reason, I don't think we can just rely on the external port check. Still perhaps we can raise a very specific error message if /bin/sh is not available inside the container.

貢獻者指南

技術棧: javadocker
領域: testing
議題類型: bug
難度: 3
預計時間: half day
活動狀態: stale
清晰度: clear
前置要求: JavaDockerTestcontainers basics
新手友善度: 50
研究方向: Investigate the InternalCommandPortListeningCheck class in the testcontainers java repository. The issue relates to #2984 and describes that the check fails when /bin/sh is not present inside the container. Consider adding a fallback or a more descriptive error message. Look at how the check currently works and propose a modification to detect the absence of /bin/sh and provide a helpful warning or alternative check.