temporalio/cli

[Bug] Dev Server concurrent execution test is incorrect and flaky

開放

#581 建立於 2024年6月4日

 (0 則留言) (1 個反應) (0 位負責人)Go (96 個分叉)auto 404
buggood first issuetests

倉庫指標

星標
 (370 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Describe the bug

We recently added an integration test that starts a total of 80 dev server, with a maximum of 8 instances running concurrently. This is used to assert, among other things, the reliability of the "get ephemeral port number" logic.

However, that test is incorrect, because it calls FailNow and similar from goroutines, which is not allowed. The test is also flaky. Incorrect usage of test APIs is like not the cause of the flakiness, but may be masking the actual errors, making the issue harder to diagnose.

Given that the CLI's test harness internally use FailNow, fixing this will likely require developing a substitute for the existing test harness.

貢獻者指南