tektoncd/pipeline

Filtered Informer is not configured fully. Too many pods are in the informer.

開放

#4,398 建立於 2021年11月26日

 (14 則留言) (0 個反應) (0 位負責人)Go (1,943 個分叉)auto 404
help wantedkind/buglifecycle/frozenpriority/important-longterm

倉庫指標

星標
 (9,013 顆星)
PR 合併指標
 (平均合併 9天 3小時) (30 天內合併 137 個 PR)

描述

Expected Behavior

The informer should have only pods with label app.kubernetes.io/managed-by=tekton-pipelines or the value of the config default-managed-by-label-value

https://github.com/tektoncd/pipeline/blob/main/config/config-defaults.yaml#L52

Actual Behavior

The informer has too many pods in his memory.

Steps to Reproduce the Problem

  1. Modify the code of the pipeline controller to display the number of pods in the informer
go func() {
	for {
		pods, err := podInformer.Lister().List(labels.Everything())
		if err != nil {
			logger.Fatal(err)
		}
		logger.Error(len(pods))
		time.Sleep(time.Second)
	}
}()
  1. Create a TaskRun
  2. Create a pod with a label app.kubernetes.io/managed-by: not-tekton-at-all

Additional Info

The filteredinformerfactory is configured here: https://github.com/tektoncd/pipeline/blob/64aff5edcbb7e6fdf22e1270f60ee37085a8d934/cmd/controller/main.go#L101 The podinformer is configured here: https://github.com/tektoncd/pipeline/blob/64aff5edcbb7e6fdf22e1270f60ee37085a8d934/pkg/reconciler/taskrun/controller.go#L53

貢獻者指南