clang importergood first issue
倉庫指標
- Star
- (69,989 star)
- PR 合併指標
- (平均合併 8天 17小時) (30 天內合併 510 個 PR)
描述
Motivation
-dump-clang-diagnostics currently does two somewhat orthogonal things:
- emits ad-hoc "remarks" on things ClangImporter is doing to stderr
- emits clang diagnostics through both clang's and swift's diagnostic engine
Proposed solution
We should extract 1) into actual remarks, and enable them with -Rclang-importer (or whatever option https://github.com/swiftlang/swift/pull/87726 ends up adding).
Alternatives considered
-dump-clang-diagnostics may be left with just 2), or also enabling -Rclang-importer by default to keep the same behavior. I personally lean towards the former to avoid tangling orthogonal concepts, but I don't have a strong opinion.
Additional information
No response