swiftlang/swift

Incorrect fix-it for static member access on instance

Open

#85,157 建立於 2025年10月27日

在 GitHub 查看
 (2 留言) (0 反應) (1 負責人)Swift (69,989 star) (10,719 fork)batch import
compilerdiagnostics qualityfix-itsgenericsgood first issueopaque parameter typesstatic declarationstype checker

描述

Description

In the following example the compiler offers to replace p with some P, which is obviously not going to work. The same applies to any P.

Reproduction

protocol P {
  static var x: Int {get}
}
func foo(p: some P) -> Int {
  p.x
}

Expected behavior

We should probably make it wrap the base in type(of:) instead.

Environment

Swift version 6.3-dev (1ae8ef0004e7405)

Additional information

No response

貢獻者指南

技術棧
swift
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Understanding of Swift protocols and genericsFamiliarity with compiler fix it mechanism
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
20
研究方向
The issue requires modifying the fix it logic in the Swift compiler. When a static member is accessed on an instance of a protocol existential (e.g., `some P`), the current fix it incorrectly suggests replacing the instance with a concrete type. The correct behavior is to wrap the base expression in `type(of:)`. The relevant code is likely in the diagnostics or constraint solver module. Check the issue comments for any additional context or pointers.