swiftlang/swift

[SR-8147] Fixit corrects .eventTrackingRunLoopMode to .RunLoop.Mode.eventTracking with invalid leading period

Open

#50,679 建立於 2018年6月29日

在 GitHub 查看
 (21 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
bugcompilerdiagnostics qualitygood first issue

描述
Previous ID SR-8147
Radar rdar://problem/41545427
Original Reporter @jckarter
Type Bug

Attachment: Download
Votes 0
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee None
Priority Medium

md5: 8dc18aea989964e226ca7f5bd1d9df9f

Issue Description:

Compiling the following code emits a fixit to change ‘.eventTrackingRunLoopMode’ to ‘.RunLoop.Mode.eventTracking’ with a leading period which does not compile since the type is fully specified already.

import AppKit

func foo(timer: Timer) {
  RunLoop.current.add(timer, forMode: .eventTrackingRunLoopMode)
}

貢獻者指南

技術棧
swift
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Swift languagecompiler diagnostics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Examine the Swift compiler's fix it emission for deprecated enum values. The bug is that a leading period is added incorrectly when the replacement is a fully qualified type. Look in the source files handling fix it generation for deprecated API replacements, likely in the diagnostics or IDE modules. Ensure that the period is only added when the expression is a dot syntax shorthand.