swiftlang/swift

[SR-6736] Enforce 16-bit limit for # of function parameters, # of tuple type element

Open

#49,285 建立於 2018年1月11日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
bugcompilergood first issue

描述
Previous ID SR-6736
Radar None
Original Reporter @DougGregor
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ea27fac0ee252473c9618a9257498092

Issue Description:

Swift's ABI uses 16 bits to store the number of parameter types in a function type and the number of element types in a tuple type. We should enforce these limits in the parser, so they don't slip through and become crashes at later phases.

貢獻者指南

技術棧
swift
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Swift compiler internalsABI understandingParser design
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Search the Swift compiler's source code, particularly in the parser (lib/Parse) for places where function types and tuple types are constructed. Add checks to ensure the number of parameters or elements does not exceed the 16 bit limit (65535). If the limit is exceeded, emit a diagnostic error. Write corresponding tests to validate the new behavior. Examine existing tests for similar limit enforcement to follow the pattern.