swiftlang/swift
[SR-6264] Unify duplicated code in GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally()
開放
#48,814 建立於 2017年11月1日
IRGencompilergood first issueimprovement
倉庫指標
- 星標
- (69,989 顆星)
- PR 合併指標
- (平均合併 8天 17小時) (30 天內合併 510 個 PR)
描述
| Previous ID | SR-6264 |
| Radar | None |
| Original Reporter | @gparker42 |
| Type | Improvement |
| Votes | 0 |
| Component/s | Compiler |
| Labels | Improvement, IRGen, StarterBug |
| Assignee | None |
| Priority | Medium |
md5: 7fe2948a0ff34a9d22f375125e2fe476
Issue Description:
Functions GlobalPropertyOpt::isVisibleExternally() and FunctionLivenessComputation::isVisibleExternally() have duplicated code that checks whether a declaration may be externally used based on its access level. This duplication should be fixed.
Possible solution: add a function to class ValueDecl to do the work, and call it from both places.