swiftlang/swift

[SR-5362] StdlibUnittest allows redeclaration of the same-named test; ignores all but last

Open

#47,936 建立於 2017年7月3日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
buggood first issuestandard library

描述
Previous ID SR-5362
Radar rdar://problem/33107335
Original Reporter @dabrahams
Type Bug
Status In Progress
Resolution
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: fc8e733c68f3cbbcf633f37b9a56c975

Issue Description:

For example, these two tests have the same name. The first one wouldn't pass, but it never gets run because of the second one.

This affects the reliability and maintainability of our testing. Someone needs to make StdlibUnittest cause a hard error in these cases, identify all the duplicated tests, strip out the bogus ones, and rename any others.

Note: the particular bogus tests referenced here will probably be gone from master by the time this bug is addressed. The links point to an older version of the file.

貢獻者指南

技術棧
swift
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Swift knowledgefamiliarity with StdlibUnittestability to search for duplicate test names
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the current state of duplicate test names in the Swift test suite. The issue references two tests in StringViews.swift (old commit), so start by searching the current validation test/stdlib/StringViews.swift for similarly named tests. Additionally, grep the entire test directory for duplicate test function names registered via StdlibUnittest. Look at the StdlibUnittest source code (likely in swift/stdlib/private/StdlibUnittest) to understand how tests are registered and where to add a hard error for duplicate names. Identify all duplicates, remove bogus ones, and rename any that need renaming. Consider checking comments on the issue for any recent activity or guidance.