swiftlang/swift

[SR-5058] Redundant Conformance Diagnostic should have an associated fixit

Open

#47,634 建立於 2017年5月31日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
bugcompilerdiagnostics qualitygood first issue

描述
Previous ID SR-5058
Radar rdar://32431756
Original Reporter @CodaFi
Type Bug
Status In Progress
Resolution

Attachment: Download
Votes 1
Component/s Compiler
Labels Bug, DiagnosticsQoI, StarterBug
Assignee interfere (JIRA)
Priority Medium

md5: 5985872320450fd433971928ef7a5b14

Issue Description:

The redundant conformance diagnostic can point at the protocol that is redundant, but doesn’t actually offer to remove it.

protocol Foo {}
struct Bar {}

extension Bar: Foo {}
extension Bar: Foo {} // redundant conformance of 'Bar' to protocol 'Foo'

貢獻者指南

技術棧
swift
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Swift languageSwift compiler basicsDiagnostic fixit API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue is to add a fixit for the redundant conformance diagnostic. Look for the diagnostic emission in the Swift compiler source, likely in lib/Sema or lib/AST. The diagnostic message is about redundant conformance, and the fixit should suggest removing the duplicate conformance declaration. Investigate existing fixits in the compiler (e.g., in LLVM's DiagnosticConsumers) to understand the API for adding fixits. The issue is labeled StarterBug and involves a localized change.