swiftlang/swift

[SR-4824] Add tests to check Collection constraints are being enforced

Open

#47,401 建立於 2017年5月7日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
buggood first issuestandard library

描述
Previous ID SR-4824
Radar rdar://problem/32134714
Original Reporter @airspeedswift
Type Bug
Votes 0
Component/s Standard Library
Labels Bug, StarterBug
Assignee djwbrown (JIRA)
Priority Medium

md5: 6b6aabc9be01be2d9974ed98c3c057f8

Issue Description:

https://github.com/apple/swift/pull/9379 removed tests confirming collection's associated types conformed to appropriate protocols e.g. MutableCollection.SubSequence: MutableCollection. Now the compiler is enforcing these, so they were just generating warnings.

They should be replaced by tests checking the compiler is enforcing these rules (by trying to create invalid collections and checking the error messages).

貢獻者指南

技術棧
swift
領域
testing
議題類型
test
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Swift basicscollection protocols
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Look at the tests removed in PR #9379 to understand what they validated. Then, create new tests that attempt to define invalid collection types and check the compiler's error messages. Use existing test files as a guide for how to structure tests that expect compiler errors.