swiftlang/swift

[SR-1111] Non-optimized builds should avoid redundant thick_to_objc_metatype conversions

開放

#43,724 建立於 2016年3月30日

 (0 則留言) (0 個反應) (0 位負責人)Swift (10,719 個分叉)batch import
IRGencompilergood first issueimprovementnon-optimized only

倉庫指標

星標
 (69,989 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Previous ID SR-1111
Radar None
Original Reporter @belkadan
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, IRGen, NotOptimizedOnly, StarterBug
Assignee None
Priority Medium

md5: ee5fa37243b2596a51a6125675863696

Issue Description:

In this code:

import Foundation
func test() -> Bool {
  let a = RunLoop.current
  let b = RunLoop.main
  return a === b
}

We're smart enough to avoid emitting two references to the metadata for NSRunLoop, but not smart enough (in -Onone builds) to avoid emitting the conversion to an ObjC Class twice, which involves a branch. We should be able to reuse the value from the first thick_to_objc_metatype conversion.

貢獻者指南