swiftlang/swift

[SR-978] Warn on do {} with only one empty catch {} block

Open

#43,590 建立於 2016年3月18日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
compilerdiagnostics qualitydo catchgood first issueimprovementmissing warningstatementsswift 5.9

描述
Previous ID SR-978
Radar None
Original Reporter @jckarter
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee MultiColourPixel (JIRA)
Priority Medium

md5: d5f41243d2aaf067f1ecd57198c44970

Issue Description:

Eric Knapp caught some sample code in the wild unwisely using an empty catch block to swallow errors:

https://twitter.com/ejknapp/status/710589235464523776

We should warn on this to encourage people to use try! to trap on unexpected errors instead.

貢獻者指南

技術棧
swift
領域
developer experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of Swift syntaxbasic compiler diagnostics knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests a warning for `do {} catch {}` blocks where the catch block is empty (i.e., only one empty catch block). To implement this, you need to add a diagnostic in the Swift compiler's semantic analysis phase. Look at existing warnings like 'unused variable' or 'redundant pattern' in the Swift compiler source (likely under `lib/Sema/` or `include/swift/AST/Diagnostics*`). The issue has a JIRA reference but no code changes yet. Check the comments for any prior discussion or proposed implementation details. The goal is to emit a warning when a catch clause is empty, encouraging use of `try!` instead.