swiftlang/swift

[SR-540] eliminate the .cpp.gyb files from the source tree

Open

#43,157 建立於 2016年1月14日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)Swift (69,989 star) (10,719 fork)batch import
bugcompilergood first issue

描述
Previous ID SR-540
Radar None
Original Reporter @lattner
Type Bug
Votes 0
Component/s Compiler
Labels Bug, StarterBug
Assignee None
Priority Medium

md5: ff02b1c09cc812ba86f097ddd5c3cf2d

Issue Description:

Gyb is a necessary artifact used in the standard library and test suite due to Swift not having a preprocessor. C++ on the other hand DOES have a preprocessor, so we should definitely not use gyb for .cpp files, we should use ".def" files consistently. Unfortunately we are using it in a couple of cases:

lib/Basic/UnicodeExtendedGraphemeClusters.cpp.gyb
stdlib/public/stubs/UnicodeExtendedGraphemeClusters.cpp.gyb
unittests/Basic/UnicodeGraphemeBreakTest.cpp.gyb

These should switch to using the C preprocessor.

貢獻者指南

技術棧
swiftcpp
領域
build systemtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C++ preprocessorgyb toolSwift project build system
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The issue identifies three specific files: lib/Basic/UnicodeExtendedGraphemeClusters.cpp.gyb, stdlib/public/stubs/UnicodeExtendedGraphemeClusters.cpp.gyb, and unittests/Basic/UnicodeGraphemeBreakTest.cpp.gyb. These currently use the gyb preprocessor and should be rewritten to use C preprocessor macros, likely by converting the gyb templates to .def files. The contributor should examine the gyb files to understand the current logic and then implement the equivalent using C preprocessor directives. The issue has no assignee or recent comments, so the approach should be validated by the maintainers.