swiftlang/swift

[SR-340] Refactor SILParser::parseSILInstruction

開放

#42,962 建立於 2015年12月22日

 (7 則留言) (0 個反應) (1 位負責人)Swift (10,719 個分叉)batch import
SILParsercompilergood first issuenfc

倉庫指標

星標
 (69,989 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Previous ID SR-340
Radar None
Original Reporter @gottesmm
Type Bug
Status In Progress
Resolution
Votes 1
Component/s Compiler
Labels Bug, StarterBug
Assignee d066z (JIRA)
Priority Medium

md5: ee6df5ef735c9655c56ca6ce06200e7e

Issue Description:

parseSILInstruction is horrible and makes me cry every time I see it. It is a method that is ~1900 lines with a huge switch in it. We should refactor it into a visitor structure. In fact it is large enough that we should consider moving it into its own file if it is possible.

貢獻者指南