swagger-api/swagger-codegen

[Javascript] Problems on deserialize text type and on file response

Open

#3,297 建立於 2016年7月5日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)HTML (12,701 star) (5,474 fork)batch import
Client: JavaScript/Node.jsIssue: Bughelp wanted

描述

Hi, I'm testing my api on the generated nodejs(javascript) client. I've found two problems, that break the client when called. First: when I've a call that return text/plain, SuperAgent initialize the body to {}, so data it's never null and doesn't verify the if condition, and in the end it gives an error. deserialize I've done a fix for my case, just adding this line in the if clauses "if (data == null || (returnType==='String' && Object.keys(data).length === 0 && data.constructor === Object))" but I think this is a bug and has to be correct

Second: I've a call where the response is a file file And this is fine on other language like java or ruby, but not on javascript. It gives this error: file2

Thanks in advance for support

I'm using Swagger-codegen version 2.2.0

貢獻者指南

技術棧
javascriptnodejs
領域
apitooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaScriptSuperAgentSwagger codegen
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue reports two bugs in the generated JavaScript client: deserializing text/plain responses where SuperAgent initializes body to {} and file responses causing errors. To fix, examine the JavaScript client template in the swagger codegen repository (likely under modules/swagger codegen/src/main/resources/JavaScript/). For the text/plain case, add a condition to check if returnType is 'String' and data is an empty object. For the file response, ensure proper handling of binary data in the generated code. Check the linked screenshots and comments for more context.