swagger-api/swagger-codegen

[golang] Default to pointers for non-primitive types

Open

#2,330 建立於 2016年3月7日

在 GitHub 查看
 (14 留言) (0 反應) (0 負責人)HTML (12,701 star) (5,474 fork)batch import
Client: GoEnhancement: GeneralGeneral: Discussionhelp wanted

描述

It generates code like this currently:

type JobWrapper struct {
    Job  Job  `json:"job,omitempty"`
}

Same with slices and what not.

It would be nice (and probably what most people would want) to have it use pointers, eg:

type JobWrapper struct {
    Job *Job  `json:"job,omitempty"`
}

貢獻者指南

技術棧
gorest api
領域
backendapitooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Knowledge of Go pointersUnderstanding of Mustache templatesFamiliarity with swagger codegen's template structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The change requires modifying the Go template files (likely in `modules/swagger codegen/src/main/resources/handlebars/` or `mustache/` directory) to add a pointer `*` before non primitive types. Review the existing template `type.mustache` or `model.mustache` for Go. The issue discussion may contain hints about which templates to change. No linked PR exists, so this is fresh work.
[golang] Default to pointers for non-primitive types · swagger-api/swagger-codegen#2330 | Good First Issue