supasate/connected-react-router

Browser history stack is modified when time travelling

Open

#36 建立於 2017年2月19日

在 GitHub 查看
 (0 留言) (3 反應) (0 負責人)JavaScript (4,741 star) (606 fork)batch import
bughelp wanted

描述

Currently, when we do time travelling, the ConnectedRouter tries to change the URL bar to match the router state in the redux store (which is changed by Redux DevTools) by using history.push (see here).

This method seems to work fine, however, internally, the real browser history stack is modified (new history is pushed on top of the stack). It would be better if we can change the URL by just moving the pointer in the history stack to match time travelling.

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
ReactReduxbrowser history API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Investigate the ConnectedRouter.js file, specifically the code at line 40 where history.push is called during time travel. Consider replacing history.push with history.replace or manipulating the history stack index directly to avoid adding new entries. Review the react router documentation on history objects for alternatives.