stufro/chordly

Make bin page searchable

開放

#37 建立於 2025年7月21日

 (4 則留言) (0 個反應) (0 位負責人)Ruby (11 個分叉)auto 404
good first issue

倉庫指標

星標
 (60 顆星)
PR 合併指標
 (平均合併 5小時 45分鐘) (30 天內合併 1 個 PR)

描述

I'd like to be able to search list of chord sheets which have been deleted.

Requirements

  • The existing search_controller.js is used to implement the search functionality
    • You can see examples of how this is used on the chord sheet and set list show pages.
    • For example in the chords sheets _library.html.slim partial, the search controller is attached to a div and the input element is configured, then in _chord_sheet.html.slim partial on line 1 we define the target and line 9 define the search term.
  • A cypress test is added in spec/cypress/e2e/chord_sheets.cy.js
    • Run rake cy:open to run tests whilst developing
    • You can define a test with it.only("...") to make cypress just run that 1 test on reload

貢獻者指南