stride3d/stride

[Animation] Messy curve/animation/evaluator API

Open

#449 建立於 2019年5月18日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C# (6,001 star) (886 fork)batch import
area-Graphicsenhancementgood first issue

描述

Release Type: Github

Version: Latest

Platform(s): Any

Describe the bug The animation/curve API as it is is not very maintainable and quite restrictive, there's no reason now that generics supports unmanaged and interface type constraints to have two implementation of a class differing in only the generic type they chose, ex : AnimationCurveEvaluatorOptimizedVector3Group / AnimationCurveEvaluatorOptimizedVector4Group. We can replace 2/3 of the files within /Animations by implementing and adding an IInterpolation interface on our math types and including it as a constraint on our generics requiring that kind of features.

貢獻者指南

技術棧
csharp
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
3-5 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C# genericsinterface constraintsStride animation systemgame engine math types
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Review the existing animation curve evaluator classes in the Animations directory (e.g., AnimationCurveEvaluatorOptimizedVector3Group.cs, AnimationCurveEvaluatorOptimizedVector4Group.cs) to identify all duplicated implementations. Propose a generic interface IInterpolation<T> for math types (Vector3, Vector4, etc.) and refactor the evaluators to use a single generic class with the IInterpolation constraint. Ensure the solution compiles and passes existing tests.