stretchr/testify

Diffs are slightly off for assert.Equal on maps

Open

#288 建立於 2016年3月23日

在 GitHub 查看
 (6 留言) (0 反應) (0 負責人)Go (25,958 star) (1,704 fork)batch import
enhancementhelp wanted

描述

It seems the map is rendered with no trailing , for the last element, so the diff catches that as a modified line.. but really the line isn't modified..

Diff:
            --- Expected
            +++ Actual
            @@ -1,5 +1,7 @@
            -(map[string]interface {}) (len=3) {
            +(map[string]interface {}) (len=5) {
              (string) (len=15) "installed.first": (string) (len=20) "2006-01-02T15:04:05Z",
              (string) (len=14) "installed.last": (string) (len=20) "2006-01-02T15:04:05Z",
            - (string) (len=23) "installed.windows.first": (string) (len=20) "2006-01-02T15:04:05Z"
            + (string) (len=23) "installed.windows.first": (string) (len=20) "2006-01-02T15:04:05Z",
            + (string) (len=22) "installed.windows.last": (string) (len=20) "2006-01-02T15:04:05Z",
            + (string) (len=30) "installed.windows.last_version": (string) (len=3) "8.1"
             }

See how installed.windows.first is different only in the trailing , !

貢獻者指南

技術棧
go
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Go programming basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
Investigate how map diffs are rendered in the assert package of testify. Look at the diff generation code, likely in the 'internal/diff' or similar directory. The issue is that the last map element lacks a trailing comma in the expected output but has it in the actual, causing a false positive diff. Check the formatting logic for map differences to ensure consistent comma handling.
Diffs are slightly off for assert.Equal on maps · stretchr/testify#288 | Good First Issue