stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 建立於 2015年11月5日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Go (1,704 fork)batch import
enhancementhelp wanted

倉庫指標

Star
 (25,958 star)
PR 合併指標
 (平均合併 6天 15小時) (30 天內合併 2 個 PR)

描述

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

貢獻者指南