stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 建立於 2015年11月5日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Go (25,958 star) (1,704 fork)batch import
enhancementhelp wanted

描述

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

貢獻者指南

技術棧
go
領域
testing
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Research the existing implementations of Equal and EqualValues in the testify codebase. Check for any existing tests that fail when types differ. Review the 10 comments for additional context and any consensus on direction. Consider backward compatibility and whether a new function might be safer.