streetwriters/notesnook

Moving editor tools around doesn't update indentation

Open

#4,350 建立於 2024年2月25日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (5,325 star) (285 fork)batch import
Platform: WebStatus: InvestigatingUnit: UI/UXgood first issue

描述

Really minor thing, doesn't break or cause a problem, just a UI glitch...

When moving an editor toolbar item out of a subgroup in to its parent, the indentation is still the same as if it were in the subgroup. (e.g. move code < > item out of subgroup 2 in to the main toolbar) It doesn't affect anything, and is fine when going out and back in to settings.

Device information: App version: 2.6.15-aa730b5-desktop OS: OS X 10.15.7 Browser: Electron 25.9.8 Pro: true

貢獻者指南

技術棧
javascriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with editor toolbar UI components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
85
研究方向
The bug occurs when moving a toolbar item from a subgroup to the parent toolbar; the indentation does not update. Investigate the editor toolbar rendering logic, likely in the `editor` package or component. Check how indentation is calculated and whether it is re evaluated on item move. Look for any logic that sets indentation based on subgroup membership and ensure it triggers a re render or update when the parent changes. No existing PRs or comments provide further clues.
Moving editor tools around doesn't update indentation · streetwriters/notesnook#4350 | Good First Issue