streamich/react-use

useLockBodyScroll doesn't restore scroll position

Open

#840 建立於 2019年12月16日

在 GitHub 查看
 (7 留言) (0 反應) (1 負責人)TypeScript (43,979 star) (3,273 fork)batch import
bughelp wanted

描述

What is the current behavior?

When useLockBodyScroll is passed a value of false, it does re-enable scrolling, however any previous scroll position is not restored.

What is the expected behavior?

The previous scroll position should be restored to the scrolled element.

A little about versions:

  • OS:
  • Browser (vendor and version):
  • React: 16.11.0
  • react-use: 13.10.1

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic React hooksJavaScript event handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The bug is in the useLockBodyScroll hook in react use. To fix, you need to save the scroll position when scrolling is locked and restore it when unlocked. Look at the hook implementation in https://github.com/streamich/react use/blob/master/src/useLockBodyScroll.ts. The current code likely sets overflow hidden but does not store/restore scrollLeft/scrollTop. Review existing comments and the assignee's work to avoid duplication.