streamich/react-use

[useMeasure] Ability to track a custom Ref

Open

#1,227 建立於 2020年5月18日

在 GitHub 查看
 (15 留言) (19 反應) (0 負責人)TypeScript (43,979 star) (3,273 fork)batch import
good first issuehelp wanted

描述

Is your feature request related to a problem? Please describe.

Currently useMeasure returns a ref which needs to be assigned a ref in the JSX. This has 2 issues:

  1. The ref is not a real useRef for eg. Does not have ref.current as a prop.
  2. If I already have a component where I have a ref, I just want to track its size changes.

Describe the solution you'd like

An API of this shape: const {width, height ... } = useMeasure({ref: currentRef});

Describe alternatives you've considered

I am using https://github.com/ZeeCoder/use-resize-observer ... in the absence of the above which I want to remove.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
understanding of React refsknowledge of useMeasure hook
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the current useMeasure implementation in react use (src/useMeasure.ts). The issue requests adding an optional `ref` parameter to the hook, allowing users to pass their own ref for observation. Research how the hook currently creates and returns a ref, and consider modifying it to use a provided ref if given. Ensure cleanup removes the ResizeObserver listener when the ref changes or component unmounts. Look at the comments for any proposed API or concerns. No linked PRs or assignees.