storybookjs/storybook

[Bug]: "useArgs" hook updates wrong story when rendered in "Stories" block

Open

#28,333 建立於 2024年6月24日

在 GitHub 查看
 (3 留言) (9 反應) (0 負責人)TypeScript (89,909 star) (10,058 fork)batch import
bughelp wantedsev:S3

描述

Describe the bug

When writing a story for a controlled component, one should expect the useArgs hook to update the args being passed to the story it is being called in. However, when used inside a "Stories" block, it updates the page's primary story instead of itself. This isn't an issue when using a "Canvas" block or any other block that selects a specific story. I'm sure this could be user error but I don't see why there would then be a discrepancy between the functionality between the "Stories" block and an individual "Story" block.

Reproduction link

https://stackblitz.com/edit/github-n2sxrc?file=src%2Fstories%2FInput.tsx

Reproduction steps

  1. Go to the "Input" docs in Storybook.
  2. Attempt to edit one of the stories under the "Stories" header.
  3. Notice that value of top story is changing, instead of the story being edited.

System

Storybook Environment Info:

  System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm <----- active
    pnpm: 8.15.6 - /usr/local/bin/pnpm

Additional context

No response

貢獻者指南

技術棧
typescriptreactnodejs
領域
frontenddeveloper experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of StorybookUnderstanding of React hooks
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the `useArgs` hook implementation in Storybook (likely in `lib/api/src/lib/useArgs.ts` or similar). Compare behavior when used inside a `Stories` block vs a `Canvas` or `Story` block. The issue suggests that in the `Stories` block, the args are being applied to the primary story instead of the targeted story. Look at how the `Stories` block renders multiple stories and how it passes context to each story. Check if there is a missing story ID propagation in the `useArgs` hook when multiple stories are rendered. Review the reproduction link provided in the issue to understand the exact scenario. Consider if the fix involves ensuring that `useArgs` targets the correct story by its ID, especially when used in a block that renders multiple stories.