storybookjs/storybook

[Bug]: Bad error message when trying to use JSX in .js file

Open

#21,662 建立於 2023年3月17日

在 GitHub 查看
 (5 留言) (18 反應) (0 負責人)TypeScript (89,909 star) (10,058 fork)batch import
bugbuilder-vitehelp wanted

描述

Describe the bug

[storybook:inject-export-order-plugin] Parse error @:22:29
file: ........./src/stories/ApiDocumentation.stories.js
ERR! Error: Parse error @:22:29
ERR!     at parse ........./node_modules/es-module-lexer/dist/lexer.cjs:1:402)
ERR!     at Object.transform (........./node_modules/@storybook/builder-vite/dist/index.js:1:3217)
ERR!     at file:///.........//node_modules/rollup/dist/es/shared/node-entry.js:24343:40

The above error will happen if your .stories.js file contains any JSX. Renaming the file to .jsx fixes the issue. I spent hours trying to figure out the problem. Some better error messaging would be nice here.

To Reproduce

Happens in sandbox project with React and Vite.

System

No response

Additional context

No response

貢獻者指南

技術棧
javascripttypescriptreactvite
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
StorybookViteJavaScript/JSX
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The fix involves improving the error message when JSX is detected in a .js file. The error originates from the inject export order plugin in the storybook/builder vite package. The solution could add a validation step to check for JSX before the es module lexer parse, and provide a more descriptive error suggesting renaming to .jsx. Look at the source file at @storybook/builder vite or the inject export order plugin. Consider using Babel or a simple regex to detect JSX.
[Bug]: Bad error message when trying to use JSX in .js file · storybookjs/storybook#21662 | Good First Issue