storybookjs/storybook

[Feature Request]: Drop dependency on `browser-assert`

Open

#21,408 建立於 2023年3月6日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (89,909 star) (10,058 fork)batch import
help wantedmaintenancesecurity

描述

Is your feature request related to a problem? Please describe

The package browser-assert which @storybook/builder-manager and @storybook/builder-webpack5 depend on has various issues according to: https://socket.dev/npm/package/browser-assert

Describe the solution you'd like

Remove the unmaintained dependency and write the 7 LOC yourself or use native methods.

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

貢獻者指南

技術棧
typescriptnodejs
領域
developer experiencetooling
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptnpm dependency managementStorybook project structure
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Locate the dependency declaration of `browser assert` in the package.json files of `@storybook/builder manager` and `@storybook/builder webpack5`. Search for imports of `browser assert` in the source code of these packages. Implement a small function that replicates the 7 line functionality (likely a simple boolean check for browser context). Remove the dependency from package.json and run the tests to ensure nothing breaks. The issue has 1 comment; check it for any additional guidance. If the replacement is straightforward, submit a PR removing the dependency.