stereobooster/react-snap

Crawl only html documents

Open

#339 建立於 2019年2月28日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)JavaScript (4,982 star) (403 fork)batch import
enhancementhelp wanted

描述

Feature Request

Is your feature request related to a problem? Please describe. Puppeteer does not handle PDF files. react-snap will crawl to them if links exist and the process will crash. There doesn't seem to be a way to ignore this.

Describe the solution you'd like I'd like the ability to be able to specify files/paths/globs to ignore as an option.

Describe alternatives you've considered I've looked at other snapshot libraries but prefer this one. I've looked at whether it's possible to pass an argument to puppeteer to handle this but it doesn't seem to be.

Teachability, Documentation, Adoption, Migration Strategy I'd imagine an option in package.json, like:

ignore: ["**.pdf"]

貢獻者指南

技術棧
javascriptnodejs
領域
toolingfrontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic JavaScriptUnderstanding of glob patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests adding an `ignore` option to skip certain file extensions during crawling. Look at the crawling logic in `src/` or `index.js` to see how links are followed. Implement a configurable ignore list (e.g., `ignore: ['**.pdf']`) and update the relevant crawling function to skip matches. Check existing tests for examples of how options are handled.