stan-dev/stan

Remove unused variational::base_family class

開放

#1,695 建立於 2015年11月19日

 (6 則留言) (0 個反應) (1 位負責人)C++ (387 個分叉)batch import
code cleanupgood first issue

倉庫指標

星標
 (2,761 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

The base class variational::base_family has no virtual methods and the one function it does define uses no member variables or functions, so can be made standalone outside of the class. Therefore, base_family should be removed.

  • remove src/stan/variational/base_family.hpp
  • move function write_error_msg_() into its own file and rename without suffix _
  • patch families/normal_meanfield.hpp and families/normal_fullrank.hpp:
    • remove references to base_family
    • change calls to write_error_msg_ to include and call new function

If the intent was to somehow pull down some of the functionality from the subclasses, then this issue should be repurposed to do that.

貢獻者指南