square/workflow-kotlin
Passing the TestScope.coroutineContext to launchForTestingFromState/Start causes a crash
開放
#983 建立於 2023年3月31日
good first issue
倉庫指標
- 星標
- (1,120 顆星)
- PR 合併指標
- (平均合併 55天 8小時) (30 天內合併 9 個 PR)
描述
workflow.launchForTestingFromStateWith(..., context = testContext, ...) fails with
Test finished
java.util.concurrent.CancellationException: Test finished
at com.squareup.workflow1.testing.WorkflowTestRuntimeKt$launchForTestingWith$2$1.invoke(WorkflowTestRuntime.kt:285)
at com.squareup.workflow1.testing.WorkflowTestRuntimeKt.unwrapCancellationCause(WorkflowTestRuntime.kt:322)
at com.squareup.workflow1.testing.WorkflowTestRuntimeKt.access$unwrapCancellationCause(WorkflowTestRuntime.kt:1)
at com.squareup.workflow1.testing.WorkflowTestRuntimeKt$launchForTestingWith$2.invoke(WorkflowTestRuntime.kt:276)
at com.squareup.workflow1.internal.util.UncaughtExceptionGuard.runRethrowingUncaught(UncaughtExceptionGuard.kt:32)
at com.squareup.workflow1.testing.WorkflowTestRuntimeKt.launchForTestingWith(WorkflowTestRuntime.kt:275)
at com.squareup.workflow1.testing.WorkflowTestRuntimeKt.launchForTestingFromStateWith(WorkflowTestRuntime.kt:210)
, but workflow.launchForTestingFromStateWith(..., context = testContext[CoroutineDispatcher.Key]!!, ...) succeed.
It may be connected with the way uncaughtExceptionHandler is set for workflow test runtime:
val uncaughtExceptionHandler = CoroutineExceptionHandler { _, throwable ->
exceptionGuard.reportUncaught(throwable)
}
....
val workflowScope = CoroutineScope(Unconfined + context + uncaughtExceptionHandler)
val outputs = Channel<OutputT>(capacity = UNLIMITED)
workflowScope.coroutineContext[Job]!!.invokeOnCompletion {
outputs.close(it)
}