spring-cloud/spring-cloud-netflix

RequestSpecificRetryHandler retries same server for SERVER_THROTTLED

Open

#2,585 建立於 2017年12月27日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)Java (4,805 star) (2,433 fork)batch import
help wanted

描述

Netflix's RequestSpecificRetryHandler allows to retry on same server for SERVER_THROTTLED error.

When the okToRetryOnAllErrors property is true, the retry handler allows to retry on the same server unconditionally without taking into account the actual error. This is useless when the server responded with SERVER_THROTTLED.

It looks like the if statement at https://github.com/Netflix/ribbon/blob/master/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java#L58-L65 should be considered first before the other conditions.

I doubt Netflix is willing to change this behavior but we could override it in SpringCloud. What do you think ?

貢獻者指南

技術棧
java
領域
backendperformance
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaUnderstanding of Ribbon retry handlersSpring Cloud Netflix basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
The issue identifies a bug in RequestSpecificRetryHandler where the okToRetryOnAllErrors flag overrides the specific check for SERVER THROTTLED, causing retries on the same server. The proposed fix is to reorder the if statement at lines 58-65 in ribbon core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java to check SERVER THROTTLED first. Examine how Spring Cloud Netflix customizes retry logic, possibly via a custom retry handler, and review the issue comments for maintainer consensus.