spring-cloud/spring-cloud-gateway

ProxyExchange discards all incoming request headers when making a request with a body.

Open

#2,559 建立於 2022年3月16日

在 GitHub 查看
 (3 留言) (2 反應) (0 負責人)Java (4,284 star) (3,204 fork)batch import
bughelp wanted

描述

Affects: spring-cloud-gateway-webflux:3.1.1

Setup Define an MVC RestController that accepts a ProxyExchange as an argument to a request handler method, and use the ProxyExchange object to issue a POST request (or any request that contains a body) to an upstream service, using a body created (or manipulated) in the request handler method.

Expected Behaviour The ProxyExchange forwards the original request headers, minus filtered sensitive headers, and Content related headers in the upstream request.

Observed Behaviour The ProxyExchange discards all original incoming headers, appending only the X-Forwarded-For and X-Forwarded-Proto headers. This behaviour is in contrast to the behaviour observed when using a ProxyExchange object to make requests to upstream services that do not contain bodies (GET, OPTIONS, etc).

貢獻者指南

技術棧
java
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaSpring Framework basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the ProxyExchange class implementation in spring cloud gateway core (likely in the `org.springframework.cloud.gateway.support` package). Investigate how headers are handled differently for requests with and without a body. The issue mentions that when there is a body, only X Forwarded For and X Forwarded Proto are appended, discarding original headers. Look for methods like `headers()` or `exchange()` in ProxyExchange and related classes. Check if there are any tests for this behavior and consider adding a unit test that reproduces the bug.