spring-cloud/spring-cloud-gateway

Validate route uri

Open

#131 建立於 2017年12月12日

在 GitHub 查看
 (14 留言) (0 反應) (0 負責人)Java (4,284 star) (3,204 fork)batch import
enhancementhelp wanted

描述

Writeup and example: https://github.com/RyanBard/scg-npe

spring-cloud-gateway version: 2.0.0.M5 spring-boot-version: 2.0.0.M7

I'm getting a NullPointerException in NettyRoutingFilter on line 67 because scheme is null. It's possible that my configuration in my application.yml is bogus (the uri and predicate Path do not match -- EDIT: I've verified that it still fails for the same reason even if they do overlap), however, it looks like the overwriting of scheme in the UriComponentsBuilder calls in RouteToRequestUrlFilter could be problematic in other situations.

I would appreciate if you could take a look.

Thank you

貢獻者指南

技術棧
javaspring
領域
backendapi
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
JavaSpring Framework basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the NullPointerException in NettyRoutingFilter line 67 due to null scheme. Review the linked example repo (https://github.com/RyanBard/scg npe) and the RouteToRequestUrlFilter logic in the same codebase. Consider adding validation of the route URI or handling null scheme gracefully. Check existing comments for any proposed fixes or discussion.